GSoC/GCI Archive
Google Code-in 2013 BRL-CAD

Update qsort() calls to bu_sort() #6

completed by: Johannes Schulte

mentors: H S Rai

This task is a follow-on to

We call qsort() in about 40 places throughout BRL-CAD.  You can run this to find most of them:

grep -r 'qsort(' src/* | grep -v other | grep -v svn

We have a new function in our LIBBU portable utility library, bu_sort(), that provides functionality nearly identical to qsort_s() on Windows or qsort_r() on Linux.  The difference between sort() and those functions is that you have to put data into global variables with sort() but you pass data as an argument with the others.  

This task involves updating five or more instances of qsort (you must at least update all occurrences in a given file) to bu_sort.

Basically, you'll take any parameter that was being accessed as a global and pass it as an argument.  If the variable can be moved from global into a local scope during the transition, even better, but the important step is to update the callback function to take an additional parameter and to access data through that parameter, not via the global.  If multiple globals are accessed, you'll need to create a struct that combines them together.

Submit your work as a patch file.

There are multiple tasks like this one in order to see all occurrences get fixed.  If you run into any qsort() call that takes more than an hour to convert, for whatever reason, let us know.